Skip to content

Conversation

@ramzieus
Copy link
Contributor

closes #56

@yegor256
Copy link
Owner

@ramzieus Thanks for your contribution, we appreciate it! Before we can merge this pull request, we need to see all CI workflows pass without errors. We can't merge the pull request into the master branch unless all workflows are green. Try to fix them, also paying attention to code style issues.

@ramzieus
Copy link
Contributor Author

@ramzieus Thanks for your contribution, we appreciate it! Before we can merge this pull request, we need to see all CI workflows pass without errors. We can't merge the pull request into the master branch unless all workflows are green. Try to fix them, also paying attention to code style issues.

Those issues are related to copyright, okay I'll fix them

lib/tago.rb Outdated
locals[locale]
end

def number_to_words(value)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ramzieus we shouldn't pollute Float class with so many methods. The only method that we can add to Float is seconds.

@ramzieus
Copy link
Contributor Author

@yegor256 I think it's better to use i18n gem for translation

@yegor256 yegor256 merged commit 233c2ae into yegor256:master Oct 31, 2025
11 checks passed
@yegor256
Copy link
Owner

@ramzieus thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

let's make it possible to print them "pretty"

2 participants